Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emr_instance_group read when emr_cluster no longer exists #26154

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Fix emr_instance_group read when emr_cluster no longer exists #26154

merged 8 commits into from
Aug 8, 2022

Conversation

adam-tylr
Copy link
Contributor

@adam-tylr adam-tylr commented Aug 6, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19552

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 6, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/emr Issues and PRs that pertain to the emr service. linter Pertains to changes to or issues with the various linters. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 6, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 8, 2022
@ewbankkit
Add CHANGELOG entry.
b5c4ea1
@ewbankkit
r/aws_emr_cluster: Rename acceptance test base configurations.
5365b9c
@ewbankkit
r/aws_emr_instance_group: Add 'TestAccEMRInstanceGroup_disappears'.
4758734 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEMRInstanceGroup_disappears' PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRInstanceGroup_disappears -timeout 180m
=== RUN   TestAccEMRInstanceGroup_disappears
=== PAUSE TestAccEMRInstanceGroup_disappears
=== CONT  TestAccEMRInstanceGroup_disappears
--- PASS: TestAccEMRInstanceGroup_disappears (702.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	707.151s
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed linter Pertains to changes to or issues with the various linters. size/XS Managed by automation to categorize the size of a PR. labels Aug 8, 2022
@ewbankkit
r/aws_emr_instance_group: Mark 'instance_count' as Computed to preven…
7a753dd 
…t diff when autoscaling is active.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccEMRInstanceGroup_basic\|TestAccEMRInstanceGroup_autoScalingPolicy' PKG=emr ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 1  -run=TestAccEMRInstanceGroup_basic\|TestAccEMRInstanceGroup_autoScalingPolicy -timeout 180m
=== RUN   TestAccEMRInstanceGroup_basic
=== PAUSE TestAccEMRInstanceGroup_basic
=== RUN   TestAccEMRInstanceGroup_autoScalingPolicy
=== PAUSE TestAccEMRInstanceGroup_autoScalingPolicy
=== CONT  TestAccEMRInstanceGroup_basic
--- PASS: TestAccEMRInstanceGroup_basic (601.07s)
=== CONT  TestAccEMRInstanceGroup_autoScalingPolicy
--- PASS: TestAccEMRInstanceGroup_autoScalingPolicy (660.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	1265.839s
ewbankkit
ewbankkit approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRInstanceGroup_' PKG=emr ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 1  -run=TestAccEMRInstanceGroup_ -timeout 180m
=== RUN   TestAccEMRInstanceGroup_basic
=== PAUSE TestAccEMRInstanceGroup_basic
=== RUN   TestAccEMRInstanceGroup_disappears
=== PAUSE TestAccEMRInstanceGroup_disappears
=== RUN   TestAccEMRInstanceGroup_Disappears_emrCluster
=== PAUSE TestAccEMRInstanceGroup_Disappears_emrCluster
=== RUN   TestAccEMRInstanceGroup_bidPrice
=== PAUSE TestAccEMRInstanceGroup_bidPrice
=== RUN   TestAccEMRInstanceGroup_sJSON
=== PAUSE TestAccEMRInstanceGroup_sJSON
=== RUN   TestAccEMRInstanceGroup_autoScalingPolicy
=== PAUSE TestAccEMRInstanceGroup_autoScalingPolicy
=== RUN   TestAccEMRInstanceGroup_instanceCount
=== PAUSE TestAccEMRInstanceGroup_instanceCount
=== RUN   TestAccEMRInstanceGroup_EBS_ebsOptimized
=== PAUSE TestAccEMRInstanceGroup_EBS_ebsOptimized
=== CONT  TestAccEMRInstanceGroup_basic
--- PASS: TestAccEMRInstanceGroup_basic (674.91s)
=== CONT  TestAccEMRInstanceGroup_sJSON
--- PASS: TestAccEMRInstanceGroup_sJSON (662.89s)
=== CONT  TestAccEMRInstanceGroup_EBS_ebsOptimized
--- PASS: TestAccEMRInstanceGroup_EBS_ebsOptimized (791.40s)
=== CONT  TestAccEMRInstanceGroup_instanceCount
--- PASS: TestAccEMRInstanceGroup_instanceCount (1136.92s)
=== CONT  TestAccEMRInstanceGroup_autoScalingPolicy
--- PASS: TestAccEMRInstanceGroup_autoScalingPolicy (660.76s)
=== CONT  TestAccEMRInstanceGroup_Disappears_emrCluster
--- PASS: TestAccEMRInstanceGroup_Disappears_emrCluster (565.84s)
=== CONT  TestAccEMRInstanceGroup_bidPrice
--- PASS: TestAccEMRInstanceGroup_bidPrice (1040.30s)
=== CONT  TestAccEMRInstanceGroup_disappears
--- PASS: TestAccEMRInstanceGroup_disappears (544.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	5979.674s

@ewbankkit
Copy link
Contributor

@adam-tylr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c976661 into hashicorp:main Aug 8, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 8, 2022
@adam-tylr adam-tylr deleted the b-19552 branch August 8, 2022 19:30
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.26.0
Development

Successfully merging this pull request may close these issues.

Error refreshing EMR Instance Group when EMR Cluster no longer exists
2 participants
@adam-tylr @ewbankkit